Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#18808 closed defect (fixed)

[Regression] In 1.10 branch test of JSONRest store fails in all browser.

Reported by: Clement Mathieu Owned by: dylan
Priority: undecided Milestone: 1.10.8
Component: Testing Version: 1.10.5
Keywords: Cc:
Blocked By: Blocking:

Description

I ran dojo core doh tests against the 1.10 branch. The test tests.store.JsonRest::testQueryIterative is failing on Firefox 38 ESR, Chrome 48 and IE 11.

Here is the log I got:

_AssertFailure: http://localhost/dev/dojo/dojo.js line 345 > 
				Function line 1 > eval:47 assertEqual() failed:
	expected
		../../dojo/tests/store=foo
	but got
		../../dojo/tests/store/foo

ERROR IN:
		 (function _getTarget(t){
			// make sure it works without the trailing slash
			store.target = store.target.slice(0, -1);
			t.is(store.target + "/foo", store._getTarget("foo"));
			// and with the slash
			store.target = store.target + '/';
			t.is(store.target + "foo", store._getTarget("foo"));
			// and with an equals sign
			store.target = store.target.slice(0, -1);
			t.is(store.target + "=foo", store._getTarget("foo"));
		})
FAILED test: _getTarget 
	Error: test timeout in testQueryIterative
	ERROR IN:
 		(function testQueryIterative(t){
			var d = new doh.Deferred();
			var i = 0;
			store.query("treeTestRoot").forEach(function(object){
				i++;
				console.log(i);
				t.is(object.name, "node" + i);
			}).then(function(){
				d.callback(true);
			});
			return d;
		})

Change History (5)

comment:1 Changed 3 years ago by dylan

Component: GeneralData
Milestone: tbd1.10.7
Owner: set to dylan
Version: 1.11.0-rc41.10.5

The API was fixed, and the tests were updated with Intern. The doh test for this is obsolete.

comment:2 Changed 3 years ago by dylan

Milestone: 1.10.71.10.8

comment:3 Changed 3 years ago by jroufa

A PR was submitted https://github.com/dojo/dojo/pull/246.

This PR removes the testQueryIterative test from the JsonRest? suite, as well as updates the _getTarget test to be current with the latest Intern test from the 1.12 branch.

Please note, the testHeaders test is still failing but this is not a straightforward backport from Intern to DOH as the Intern tests require stubs and a different organization for that particular test. This is something we should look into if time permits.

comment:4 Changed 3 years ago by dylan

Component: DataTesting
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.