Changes between Initial Version and Version 2 of Ticket #18792


Ignore:
Timestamp:
Feb 8, 2016, 7:07:42 PM (6 years ago)
Author:
Jared Jurkiewicz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18792

    • Property Owner set to Evan
    • Property Priority changed from undecided to high
    • Property Component changed from General to DojoX Grid
    • Property Milestone changed from tbd to 1.11
  • Ticket #18792 – Description

    initial v2  
    55        row.push(func(this._getExportDataForCell(arg_obj.rowIndex,
    66
    7 The problem here is that _formatCSVCell refers to 'this' in its implementation, but this deference here breaks what 'this' will resolve to (It gets window) as it is now an unattached function scope.  It needs to be func = lang.hitch(this, this._formatCSVCell);
     7The problem here is that _formatCSVCell refers to 'this' in its implementation, but this deference here breaks what 'this' (if(result.indexOf(this._separator) >= 0 || result.search(/[" \t\r\n]/) >= 0){ ... )  will resolve to (It will now resolve to window) as it is now an unattached function scope.  It needs to be func = lang.hitch(this, this._formatCSVCell);
    88
    9 Without fixing this, any content with a , in it will fail as it won't escape the ,.
     9Without fixing this, any content with a , in it will fail as it won't escape the ,.  We had a customer hit this issue.
    1010
    1111Patch forthcoming.