CSVWriter of EnhancedDatagrid has a bug with how it formats cells

[Jared Jurkiewicz]

CSVWriter of EnhancedDatagrid? has a bug with how it formats cells. Specifically it is this code:

func = this._formatCSVCell;

..

row.push(func(this._getExportDataForCell(arg_obj.rowIndex,

The problem here is that _formatCSVCell refers to 'this' in its implementation, but this deference here breaks what 'this' (if(result.indexOf(this._separator) >= 0

result.search(/[" \t\r\n]/) >= 0){ ... ) will resolve to (It will now resolve to window) as it is now an unattached function scope. It needs to be func = lang.hitch(this, this._formatCSVCell);

Without fixing this, any content with a , in it will fail as it won't escape the ,. We had a customer hit this issue.

Patch forthcoming.

[Jared Jurkiewicz]

Pull request for this: ​https://github.com/dojo/dojox/pull/232

[Jared Jurkiewicz <[email protected]…>]

In 18cf246/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Jared Jurkiewicz <[email protected]…>]

In f57ecf6/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Jared Jurkiewicz <[email protected]…>]

In 5ac6237/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Jared Jurkiewicz <[email protected]…>]

In 3c45e2a/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?