Opened 4 years ago

Last modified 3 years ago

#18788 closed defect

Strict mode compatibility — at Version 1

Reported by: dylan Owned by:
Priority: undecided Milestone: 1.14
Component: Core Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dylan)

It was pointed out that getting declared classes to be strict mode compatible is perhaps as simple as making this change throughout:

// strict mode incompatible
foo: function() {
    this.inherited(arguments);
}

// strict mode compatible
foo: function foo() {
    this.inherited({callee: foo}, arguments);
}

I'll consider this change for 1.12 if it really is that simple, though the number of places where this might need to change is extensive.

The main motivation is that TypeScript? 1.8 now always emits strict mode, which makes typings for using Dojo nearly useless. See https://github.com/Microsoft/TypeScript/issues/3576 and https://github.com/Microsoft/TypeScript/issues/6819 . This last point is no longer relative as TS allows you to emit modules that are not in strict mode.

Change History (1)

comment:1 Changed 3 years ago by dylan

Description: modified (diff)
Milestone: 1.121.14
Note: See TracTickets for help on using tickets.