Opened 5 years ago

Last modified 4 years ago

#18774 new defect

Linting errors in dojo.js

Reported by: dylan Owned by: Rawld Gill
Priority: high Milestone: 1.14
Component: Loader Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

There are a number of linting errors exist in dojo.js that should be fixed:

  • Redeclaration of i inside of 
    if(has("native-xhr") && !has("dojo-force-activex-xhr")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L303

  • Redeclaration of i inside of 
    if(has("dojo-cdn") || has("dojo-sniff")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L678

  • 5 uses of dojoDir out of scope inside of 
    if(has("dojo-cdn")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L724-L729

  • Redeclaration of scripts, script, and i inside of 
    if(has("dojo-inject-api")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L1694-L1696

  • Use of i out of scope inside of 
    if(has("dojo-combo-api") && isArray(targetModule)){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L1859

  • Use of computeMapProg and computeAliases out of scope inside of 
    if(has("dojo-publish-privates")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L1923-L1924

  • Use of delayedModuleConfig out of scope inside of 
    if(has("dojo-config-api")){

​https://github.com/dojo/dojo/blob/d28eb010cce1b4f977520357a4cbc5191da886a6/dojo.js#L1955

Change History (3)

comment:1 Changed 5 years ago by dylan

Milestone: 1.11 → 1.12

comment:2 Changed 5 years ago by dylan

Milestone: 1.12 → 1.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:3 Changed 4 years ago by dylan

Milestone: 1.13 → 1.14
Note: See TracTickets for help on using tickets.