Opened 5 years ago
Closed 5 years ago
#18765 closed defect (invalid)
Mover does not call this.destroy() in onMouseUp
Reported by: | greenkarmic | Owned by: | greenkarmic |
---|---|---|---|
Priority: | undecided | Milestone: | tbd |
Component: | DnD | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
dojo.dnd.Moveable does "new this.mover" each time it's onDragDetected is called, which creates a new dojo.dnd.Mover. Mover creates a bunch of mouse event handlers in the constructor. Mover onMouseUp is supposed to call destroy to clear all these events, but it doesn't (at least not on Desktop). This means that each time Moveable onDragDetected is called, you end up with more and more event handlers for Mover.
Change History (2)
comment:1 Changed 5 years ago by
Owner: | set to greenkarmic |
---|---|
Status: | new → pending |
comment:2 Changed 5 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
On both Chrome desktop and Firefox desktop I'm showing that
Mover.onMouseUp()
callsMover.destroy()
, which removes the event handlers. That's not happening for you? It's this code:PS: This code is a mess. Since
Moveable
callsnew this.mover
,Moveable
should be the one to calldestroy this.mover
. But, AFAICT it's working.