Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18758 closed defect (fixed)

Accessibility violation on dijit.Editor setting lang=""

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.10.5
Component: Editor Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Sometimes the editor gets a lang="" setting on its DOM node. This is an illegal value.

The problem started with ​https://github.com/dojo/dijit/commit/167cd414152e4629a9ee6d8b91d08fbd5696b911 and #16140.

It only happens in the following two cases:

  1. The application didn't put a lang="en" (or some other language setting) on the main page's <html> node. That's an error in the application itself, so we don't need to worry about fixing it in Editor.
  2. The Editor is created programatically, without specifying a setting for lang.

This latter case should be handled by the Editor.

Change History (4)

comment:1 Changed 5 years ago by bill

Description: modified (diff)

comment:2 Changed 5 years ago by bill

Milestone: tbd → 1.10.5
Owner: set to bill
Status: new → assigned

comment:3 Changed 5 years ago by Bill Keese <[email protected]…>

Resolution: → fixed
Status: assigned → closed

In 006f679d7bb2562dc29b0d5ccb5e7440b79211fa/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:4 Changed 5 years ago by Bill Keese <[email protected]…>

In 052a273935de20d345f05e7d344121325d381cce/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.