dojox/mobile/Slider becomes unusable in ScrollablePane with same direction

[fabrizio.cucci]

Hi,

I was building a custom widget containing a horizontal dojox/mobile/Slider placed in a horizontal dojox/mobile/ScrollablePane.

When I tried to move the slider handle I discovered something wonderful: not only it moves but the whole custom widget moves too! :)

I think that the proper behavior would be to not propagate the drag event when it happens on the "TouchBox?" and the "Handle" elements of the slider.

Adding:

e.stopPropagation();

as first line of the "beginDrag" function here:

​https://github.com/dojo/dojox/blob/1.10/mobile/Slider.js

seems to work fine but I don't know if it might have unwanted side effects.

Thanks, Fabrizio

[fabrizio.cucci]

Created pull request:

​https://github.com/dojo/dojox/pull/202

[Patrick Ruzand]

hi, do you reproduce on master too ? (and if you have a simple reproducible sample ready (jsfiddle, gist, etc), would be even greater )

[dylan]

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

[dylan]

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

[dylan]

Moving back to 1.12 since this one has a PR that looks easy to accept.

[Michael Van Sickle <[email protected]…>]

In e813541/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <[email protected]…>]

In 75ed78a/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <[email protected]…>]

In 76581994/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?