Opened 6 years ago

Closed 6 years ago

#18741 closed defect (fixed)

dojox.layout.dock use setTimeout without testing _beingDestroyed causing issue

Reported by: thierry.chaudy Owned by: bill
Priority: undecided Milestone: 1.11
Component: Dojox Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:


In case of Unit Testing, my widget is created and destroyed. The destroy is called after the _positionDock is firered, but before the code thas is in the setTimeout.

So this error is raised:

TypeError?: Cannot read property 'style' of null at null.<anonymous> <src/dojox/layout/Dock.js:68:26> at lang.hitch <src/dojo/_base/lang.js:386:55>

This part of code should test this._beingDestroyed to be run or not in order to avoid accessing dom elements when the widget is destroyed.

Change History (3)

comment:1 Changed 6 years ago by bill

Alternately (probably better) just call this.defer() rather than calling setTimeout() directly.

comment:2 Changed 6 years ago by bill

Milestone: tbd1.11
Owner: changed from Adam Peller to bill
Status: newassigned

comment:3 Changed 6 years ago by Bill Keese <[email protected]…>

Resolution: fixed
Status: assignedclosed

In 0442c83fcfa746187933bc00e7b03bf204c4ecf6/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.