Changes between Initial Version and Version 1 of Ticket #18726


Ignore:
Timestamp:
Oct 3, 2015, 5:18:16 AM (6 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18726 – Description

    initial v1  
    1 Both test_scroll.html and window.js are accidentally including IE8, because the `has("trident")` flag is actually truthy for IE8 - IE11, not just IE11. This code from windows.js:
     1Both test_scroll.html and window.js are accidentally including IE8, because the `has("trident")` flag is actually truthy for IE8 - IE11, not just IE11.  The changes from https://github.com/dojo/dojo/commit/a832214a342b6e03ad4a9b1669fae71c7938c44b.
     2
     3This code from windows.js:
    24
    35{{{#!js
     
    1214}}}
    1315
     16This line is also wrong and may be breaking stuff:
     17
     18{{{#!js
     19if(rtl && ((isIE == 8 && !backCompat) || isIE >= 9 || has("trident"))){ s = -s; }
     20}}}
     21
    1422Relatedly, this code from test_scroll.html (deleted in master branch but in 1.10 and earlier) is inadvertently (and unnecessarily) skipping most of the tests on IE8:
    1523
     
    1826      ["_strict", "_quirks", "_loose_rtl", "_quirks_rtl" ];
    1927}}}
     28
     29So I'm guessing that https://github.com/dojo/dojo/commit/a832214a342b6e03ad4a9b1669fae71c7938c44b introduced some bugs in IE8 but they are being masked in the regression results.