#18726 closed defect (fixed)
[regression] scrollIntoView() broken for IE8 quirks RTL
| Reported by: | bill | Owned by: | bill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.7.9 |
| Component: | Core | Version: | 1.7.7 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
The changes from https://github.com/dojo/dojo/commit/a832214a342b6e03ad4a9b1669fae71c7938c44b broke scrollIntoView() on IE8 for quirks RTL, and then masked the error by inadvertently disabling those tests on IE8.
The mistake was because Mark was thinking the has("trident") is just for IE11+, but it's actually truthy for IE8 - IE11.
Change History (5)
comment:1 Changed 4 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 4 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | tbd → 1.7.9 |
| Owner: | set to bill |
| Status: | new → assigned |
| Summary: | scrollIntoView() suspicious code for IE8 → [regression] scrollIntoView() broken for IE8 quirks and loose mode |
| Version: | 1.10.4 → 1.7.7 |
comment:3 Changed 4 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | [regression] scrollIntoView() broken for IE8 quirks and loose mode → [regression] scrollIntoView() broken for IE8 quirks RTL |
comment:4 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 Changed 4 years ago by
| Type: | task → defect |
|---|
Note: See
TracTickets for help on using
tickets.
Fixed in 9362c6e8674471e9ea8666924c623fd95606e531, 6ddef724689b5b81af979b96632fed6029324709, 4ed9eb48c0c41dba64295e3f078c480f740b8b0a, 033f82428fd482154d1ece3d41f05311c7a77559, 15e3d45ed3f66c8e06dd43649628b09ed6e9e40a.