Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18721 closed defect (fixed)

form/Select throws an error when it has 0 or 1 option and keyboard navigation is used

Reported by: adros Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Method '_getNextFocusableChild' in _keyNavMixin may return null, which is case of Select with 0 or 1 option. But method '_keyboardSearch' is not ready for this and an error is raised from '_keyboardSearchCompare' method.

This can be simulated also in 'dijit/tests/form/test_Select.html', focus to 'Initial Empty' or 'Single Item' select, and press e.g. 'a' (while the dropdown is closed) and see errors in console.

I will create a pull request that fixes this issue.

Change History (4)

comment:1 Changed 5 years ago by Bill Keese <[email protected]…>

Resolution: → fixed
Status: new → closed

In cef0a828574cc9f9f80f8bce0a46b7f293630232/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:2 Changed 5 years ago by Bill Keese <[email protected]…>

In 6b803a923979d42e7433f3e2cf9b76bf80598d76/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:3 Changed 5 years ago by Bill Keese <[email protected]…>

In 5aee12230d3a6ff5175969f78ddeaa7f3881b376/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:4 Changed 5 years ago by bill

Milestone: tbd → 1.9
Note: See TracTickets for help on using tickets.