Opened 5 years ago
Closed 5 years ago
#18717 closed defect (fixed)
exception calling getIeDocumentElementOffset() on IE11
Reported by: | dylan | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.9.8 |
Component: | Core | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
I've received a report that https://github.com/dojo/dojo/blob/db66e918cd5a736fa4023741ace82e1bdc0fb612/dom-geometry.js#L434 is causing an issue within IE11, with the vague details of:
Error: Object doesn't support property or method 'getIeDocumentElementOffset'
The likely cause is that we need a feature test here, rather than a UA sniff. We should check this for IE11 and Edge.
Change History (6)
comment:1 Changed 5 years ago by
comment:2 Changed 5 years ago by
PS: The call to has("dom-addeventlistener")
in normalizeEvent()
is goofy, since it's really trying to test whether events define pageX
/pageY
. But I guess it's good enough.
comment:3 Changed 5 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
I'll fix this one; I'm doing some other fixes in core now.
comment:4 Changed 5 years ago by
Summary: | dojo/dom-geometry IE11 feature detection → exception calling getIeDocumentElementOffset() on IE11 |
---|
comment:5 Changed 5 years ago by
Milestone: | 1.11 → 1.9.8 |
---|
comment:6 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed in a7a5646855dfe5b25f6b0c1e1c447a9b7342c110 and more cleanup in 779e4e2315418ce406262540891ee8db3017f65a.
Backported in bde5d981f570a1c95b3fbb038f7edc77d97c3757 and 0aa20f7df1048587eae5b316d8861a33900f637b.
Hmm, that is vague, and mysterious. There's no point to adding any feature tests here though. You could simply change
to be:
Better yet, since we desupported IE6 and IE7 years ago, you can change that whole code block to be:
... and then stop calling that method internally, since it doesn't do anything.
BTW, the only way the user could be hitting that error is if both
has("ie")
andhas("dom-addeventlistener")
are falsy. So I doubt the problem is happening on IE11 as they claim. Probably it's something weird with an embedded browser based on IE code.