Opened 5 years ago

Closed 5 years ago

#18685 closed defect (fixed)

[patch][cla][pr] CSS styling of Dojox.Calendar breaks if surrounding document styles table

Reported by: ChrisOwens Owned by: dg
Priority: low Milestone: 1.11
Component: DojoX Widgets Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Embedding a dojox.calendar.ColumnView within a page that has styled table or td to have a background causes the grid and column lines of the calendar to be invisible.

This is because ColumnView creates two div elements, dojoxCalendarGridTable and dojoxCalendarContainer, which transparently overlays it and catches mouse events, etc.

But if, in the CSS, there is any background styling on table or td, it causes dojoxCalendarContainer's table to hide the underlying dojoxCalendarGridTable

Possible fix is to add this to dojox/calendar/themes/*/ColumnView.less: 

div.dojoxCalendarContainer table {
    background-color: transparent;
}

div.dojoxCalendarContainer table td{
    background-color: transparent;
}

div.dojoxCalendarContainer table tr{
    background-color: transparent;
}

Change History (6)

comment:1 Changed 5 years ago by dylan

Milestone: tbd → 1.11
Owner: changed from dante to dylan
Status: new → assigned

comment:2 Changed 5 years ago by dylan

Priority: undecided → low

comment:3 Changed 5 years ago by dylan

Owner: changed from dylan to dg

Pull request created at ​https://github.com/damiengarbarino/dojo-calendar/pull/114

comment:4 Changed 5 years ago by dylan

Summary: CSS styling of Dojox.Calendar breaks if surrounding document styles table → [patch][cla][pr] CSS styling of Dojox.Calendar breaks if surrounding document styles table

comment:5 Changed 5 years ago by dylan

Milestone: 1.11 → 1.12

Moving to 1.12

comment:6 Changed 5 years ago by dylan

Milestone: 1.12 → 1.11
Resolution: → fixed
Status: assigned → closed

Fixed as ​https://github.com/damiengarbarino/dojo-calendar/commit/1fb6d3403b63ca091dcd974dc48db6a588dc2d66

Note: See TracTickets for help on using tickets.