Opened 4 years ago

Closed 4 years ago

#18672 closed defect (fixed)

dojox/mobile/deviceTheme: on Android 5 and 6, the old android theme loads instead of the newer "holodark" theme

Reported by: Adrian Vasiliu Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.10.5
Component: DojoX Mobile Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

dojox/mobile/deviceTheme relies on UA sniffing for mapping a particular theme to each platform. Since Android 5, it loads the old android theme instead of the newer "holodark" theme which should load for all Android 4+.

The UA under Android 6 (preview) is the following: Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MPA44I) AppleWebKit?/537.36 (KHTML, like Gecko) Chrome/44.0.2403.133 Mobile Safari/537.36

Change History (8)

comment:1 Changed 4 years ago by Adrian Vasiliu

Owner: changed from Patrick Ruzand to Adrian Vasiliu
Status: newassigned

comment:2 Changed 4 years ago by Adrian Vasiliu

This fix is intended for being applied to master and to the 1.10 and 1.9 branches. (The holodark theme has been introduced in 1.9; it does not exist in 1.8.x).

comment:3 Changed 4 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: fixed
Status: assignedclosed

In d4ed9291f36f5e421f79bfe5312adf0ce5c98a2a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 4 years ago by Adrian Vasiliu <vasiliu@…>

In 352122f68a3bf00cc16eaa15911a6c30846a7b1e/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 4 years ago by Adrian Vasiliu <vasiliu@…>

In 3d0e89d301c25f19ae1873418be4a48f66059f77/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 4 years ago by Adrian Vasiliu

Resolution: fixed
Status: closedreopened

comment:7 Changed 4 years ago by Adrian Vasiliu

Milestone: tbd1.10.5

comment:8 Changed 4 years ago by Adrian Vasiliu

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.