Opened 4 years ago

Closed 4 years ago

#18666 closed defect (invalid)

dojo/node! path error

Reported by: fbengrid Owned by:
Priority: undecided Milestone: tbd
Component: Core Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Hiya,

Following the 2 reported issues:

https://bugs.dojotoolkit.org/ticket/17186 https://bugs.dojotoolkit.org/ticket/16414

It seems the patch created at the line https://github.com/dojo/dojo/blob/c58335c35155178b316953ec07d06d1fb8b16e54/node.js#L67 didn't take into account a declaration like

 'dojo/node!../../myFile.js'

for a file path relative to the current file (the one with the dojo node declaration).

The test should probably be :

if (/^\.\//.test(id)) {
...

Note: I was testing this on 1.10.5-pre which has the same node;js file as version 1.10.4.

Best regards,

Change History (2)

comment:1 Changed 4 years ago by fbengrid

Please disregard this ticket.

By changing the layout of the node modules in regard to the dojo location I was able to make it work with the original if test as it was.

comment:2 Changed 4 years ago by bill

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.