Opened 4 years ago

Last modified 20 months ago

#18650 assigned defect

Packaged version of Rhino broken when compiling indexeddbshim

Reported by: mlaponder Owned by: Rawld Gill
Priority: low Milestone: 1.14
Component: ShrinkSafe Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

When trying to build with the indexeddbshim package https://github.com/axemclion/IndexedDBShim the dojo build fails with the message:

OPTIMIZER FAILED: InternalError?: missing name after . operator

This is caused by the use of the delete as an object key. This doesn't occur with the latest version of Rhino.

Change History (9)

comment:1 Changed 4 years ago by mlaponder

Replacing

IDBObjectStore.prototype.delete = function(key) {
// ....
};

with

IDBObjectStore.prototype["delete"] = function(key) {
// ....
};

makes Rhino happy, but of course we don't want to modify third party libraries.

comment:2 Changed 4 years ago by gitgrimbo

The following seems to be a quick verification of the above (run from a dojo/util folder):

$ java -cp ./shrinksafe/js.jar:./closureCompiler/compiler.jar:./shrinksafe/shrinksafe.jar org.mozilla.javascript.tools.shell.Main -e "function F(){} F.prototype.delete = 1;"
js: "<command>", line 1: missing name after . operator
js: function F(){} F.prototype.delete = 1;
js: .................................^

comment:3 Changed 3 years ago by dylan

Component: ShrinkSafeDojoX Data
Milestone: tbd1.11
Owner: changed from Richard Backhouse to dylan
Status: newassigned

comment:4 Changed 3 years ago by dylan

Component: DojoX DataShrinkSafe

Sorry, I mis-read this at first and thought you meant that dojox/store/db/IndexedDB was causing this issue.

Shrinksafe is not actively maintained, as Closure and Uglify are more actively maintained. That said, we'll see if we can update to the latest version of Rhino without issues.

comment:5 Changed 3 years ago by dylan

Priority: undecidedlow

comment:6 Changed 3 years ago by dylan

Owner: changed from dylan to Rawld Gill

Spoke with Rawld, he's going to look into helping with this in January hopefully.

comment:7 Changed 3 years ago by dylan

Milestone: 1.111.12

Unfortunately this isn't going to happen in the time for 1.11.

If someone wants to spend some time working on this, we will consider a fix for 1.12.

comment:8 Changed 3 years ago by dylan

Milestone: 1.121.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:9 Changed 20 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.