Opened 4 years ago

Closed 3 years ago

#18649 closed enhancement (invalid)

Switching localization and Cookie plugin for enhanced grid

Reported by: Alex_IZA Owned by: Alex_IZA
Priority: undecided Milestone: 1.13
Component: DojoX Grid Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Columns names are localized in grid. When user change the localization on web page, the name of grid columns is changed.

Module dojox/grid/enhanced/plugins/Cookie, in function “var _loadColumnOrder = function (colOrder, grid)”

It contains condition: if (json.toJson({'name': cell.name, 'field': cell.field}) == json.toJson(cellInfo)) {

if (cell.field == cellInfo.field) {

break;

}

Of couse the cell.name != cellInfo.name (from cookie), because the names of the current cell and the name of cell from cookie vary after user did switching localization.

Why not compare only cell.fields: if (cell.field == cellInfo.field) {

break;

}

And change function code _saveColumnOrder: return {

"name": cell.name, "field": cell.field

};

Change History (3)

comment:1 Changed 4 years ago by Alex_IZA

I forgot to add effects. Now after switching localization the grid don't have any clomuns.

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.12
Owner: changed from Evan to Alex_IZA
Status: newpending

Given that this module is deprecated, we suggest using dgrid or gridx. That said, if you want to create a pull request per our contribution guidelines ( https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md ), I will review for 1.12.

comment:3 Changed 3 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.