Opened 4 years ago

Closed 4 years ago

#18648 closed defect (fixed)

Intern conversion broke build

Reported by: bill Owned by: dylan
Priority: blocker Milestone: 1.11
Component: BuildSystem Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Now it spits out a bunch of errors about the modules in node_modules:

$ ./build.sh --profile profiles/demos-all.profile.js
...
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/example; error: TypeError: Cannot call method 'red' of undefined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/test; error: TypeError: Cannot set property 'mode' of undefined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/themes/winston-dark; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/themes/winston-light; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/dateformat/test/test_weekofyear; error: TypeError: undefined is not a function
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/eventemitter2/index; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/Gruntfile; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/lib/exit; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/test/exit_test; error: TypeError: Cannot read property 'exec' of undefined

Workaround is to remove dojo/node_modules directory.

Change History (10)

comment:1 Changed 4 years ago by dylan

Owner: changed from Rawld Gill to dylan
Status: newassigned

We need to update https://github.com/dojo/dojo/blob/master/dojo.profile.js to ignore the node_modules directory (and really we should do that same for dijit and dojox and any other package like dgrid and dstore too).

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.11
Priority: undecidedblocker

comment:3 Changed 4 years ago by bill

and really we should do that same for dijit and dojox and any other package like dgrid and dstore too

Yeah, that's why I wonder if it should be changed in a more central place (i.e. in the javascript), so node_modules/ is ignored the same way as .git/ folders etc.

comment:4 in reply to:  3 Changed 4 years ago by dylan

Replying to bill:

and really we should do that same for dijit and dojox and any other package like dgrid and dstore too

Yeah, that's why I wonder if it should be changed in a more central place (i.e. in the javascript), so node_modules/ is ignored the same way as .git/ folders etc.

I need to think through the implications of what we could do. The complication I see with a more general approach is if someone installs Dojo with npm, as Dojo itself will then live inside of a node_modules folder.

comment:7 Changed 4 years ago by dylans <dylan@…>

In eca8567a89e7163c7d882e52425f154d9f904ced/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Version 0, edited 4 years ago by dylans <dylan@…> (next)

comment:10 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In bc3eb94fe51a14de804db46ba02436f7ceaeb3fb/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.