Intern conversion broke build

[bill]

Now it spits out a bunch of errors about the modules in node_modules:

$ ./build.sh --profile profiles/demos-all.profile.js
...
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/example; error: TypeError: Cannot call method 'red' of undefined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/test; error: TypeError: Cannot set property 'mode' of undefined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/themes/winston-dark; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/colors/themes/winston-light; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/dateformat/test/test_weekofyear; error: TypeError: undefined is not a function
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/eventemitter2/index; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/Gruntfile; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/lib/exit; error: ReferenceError: module is not defined
error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/node_modules/grunt/node_modules/exit/test/exit_test; error: TypeError: Cannot read property 'exec' of undefined

Workaround is to remove dojo/node_modules directory.

[dylan]

We need to update ​https://github.com/dojo/dojo/blob/master/dojo.profile.js to ignore the node_modules directory (and really we should do that same for dijit and dojox and any other package like dgrid and dstore too).

[bill]

and really we should do that same for dijit and dojox and any other package like dgrid and dstore too

Yeah, that's why I wonder if it should be changed in a more central place (i.e. in the javascript), so node_modules/ is ignored the same way as .git/ folders etc.

[dylan]

Replying to bill:

and really we should do that same for dijit and dojox and any other package like dgrid and dstore too

Yeah, that's why I wonder if it should be changed in a more central place (i.e. in the javascript), so node_modules/ is ignored the same way as .git/ folders etc.

I need to think through the implications of what we could do. The complication I see with a more general approach is if someone installs Dojo with npm, as Dojo itself will then live inside of a node_modules folder.

[dylan]

PRs at: ​https://github.com/dojo/dojo/pull/165 ​https://github.com/dojo/dijit/pull/102 ​https://github.com/dojo/dojox/pull/195

[dylan]

Fixed in master for dojo with ​https://github.com/dojo/dojo/commit/c9c04061f13f50db35f694c04967c99217127bf2

[dylans <[email protected]…>]

In eca8567a89e7163c7d882e52425f154d9f904ced/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[dylan]

Fixed in master for dojox with ​https://github.com/dojo/dojox/commit/eca8567a89e7163c7d882e52425f154d9f904ced

[dylan]

Fixed in master for themes with ​https://github.com/dojo/themes/commit/3685c0878789f75f254fbd48d57a8e22ca5d5b2d

[dylans <[email protected]…>]

In bc3eb94fe51a14de804db46ba02436f7ceaeb3fb/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?