Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18629 closed enhancement (fixed)

dojo/date/locale.format() is slow

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.8.11
Component: Core Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

TimeTextBox? can take a while to load the drop down because dojo/date/locale.format() is slow. I'll submit a PR w/some caching that reduces the render time from 1000ms to 200ms (on chrome on my mac).

See original ticket #18625.

Attachments (1)

_TimePicker.html​ (782 bytes) - added by bill 4 years ago.
benchmark

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by bill

Milestone: tbd → 1.11
Owner: set to bill
Status: new → assigned
Summary: dojo/date/locale.format is slow → dojo/date/locale.format() is slow
Type: defect → enhancement

Changed 4 years ago by bill

Attachment: _TimePicker.html​ added

benchmark

comment:2 Changed 4 years ago by dylan

Resolution: → fixed
Status: assigned → closed
Version: 1.10.4 → 1.8.10

Closed via 30bb2f5f78d93fe479c9a94267150094b9cf483e (master), 205a6359dd7142843494239e3b39b7dfb64896d5 (1.10), 1a46b2873151a8a7c6fee76add1df4f932a6771b (1.9), and 3dc17a4c1350cc8f0710e439d45a734dac29021c (1.8)

comment:3 Changed 4 years ago by dylan

Milestone: 1.11 → 1.8.11
Version: 1.8.10 → 1.10.4
Note: See TracTickets for help on using tickets.