Opened 7 years ago
Closed 7 years ago
#18619 closed enhancement (fixed)
[PATCH][CLA] Let Toaster use ownerDocument instead of win.body()
Reported by: | youngho | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.11 |
Component: | DojoX Widgets | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Let Toaster use ownerDocument instead of win.body(). then we can use toaster easily in the iframe such as dijit/Editor also.
I attach a patch.
Attachments (1)
Change History (3)
Changed 7 years ago by
Attachment: | Toaster.patch added |
---|
comment:1 Changed 7 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | changed from dante to bill |
Status: | new → assigned |
comment:2 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Looks good to me. Youngho, BTW, a few years ago we switched from attaching patches to submitting pull requests in github (https://github.com/dojo/dojox/pulls), so that's now the preferred method.
I can check in this patch though.