Opened 4 years ago

Closed 4 years ago

#18619 closed enhancement (fixed)

[PATCH][CLA] Let Toaster use ownerDocument instead of win.body()

Reported by: youngho Owned by: bill
Priority: undecided Milestone: 1.11
Component: DojoX Widgets Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Let Toaster use ownerDocument instead of win.body(). then we can use toaster easily in the iframe such as dijit/Editor also.

I attach a patch.

Attachments (1)

Toaster.patch (990 bytes) - added by youngho 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by youngho

Attachment: Toaster.patch added

comment:1 Changed 4 years ago by bill

Milestone: tbd1.11
Owner: changed from dante to bill
Status: newassigned

Looks good to me. Youngho, BTW, a few years ago we switched from attaching patches to submitting pull requests in github (https://github.com/dojo/dojox/pulls), so that's now the preferred method.

I can check in this patch though.

comment:2 Changed 4 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 373799782349701f1fa145ab4c08ad48dd114705/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.