Opened 6 years ago

Closed 5 years ago

#18613 closed defect (fixed)

[patch][cla][pr] dojox/dgauges/CircularValueIndicator RefreshRendering should check for null scale or _gfxGroup

Reported by: ChrisOwens Owned by: dg
Priority: low Milestone: 1.11
Component: Dojox Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

The refreshRendering method of dojox/dgauges/CircularValueIndicator should check for null scale or null _gfxGroup and do nothing if either is null. (see the corresponding method in ScaleIndicatorBase?).

This is exposed in widgets where an indicator is created at construct time but is not added to a scale until the indicator's value is set to a non-null value (or, when the indicator is removed from its scale in order to make it invisible)

Change History (5)

comment:1 Changed 5 years ago by dylan

Milestone: tbd → 1.11
Owner: changed from Adam Peller to dylan
Status: new → assigned

comment:2 Changed 5 years ago by dylan

Priority: undecided → low

comment:3 Changed 5 years ago by dylan

Owner: changed from dylan to dg

Pull request created at ​https://github.com/dmandrioli/dgauges/pull/22 . Thanks for the ticket @ChrisOwens?.

comment:4 Changed 5 years ago by dylan

Summary: dojox/dgauges/CircularValueIndicator RefreshRendering should check for null scale or _gfxGroup → [patch][cla][pr] dojox/dgauges/CircularValueIndicator RefreshRendering should check for null scale or _gfxGroup

comment:5 Changed 5 years ago by dylan

Resolution: → fixed
Status: assigned → closed

Fixed in ​https://github.com/dmandrioli/dgauges/commit/2bfcf9bde11636e90e00b84fea7cb1999869883a .

Note: See TracTickets for help on using tickets.