[PATCH][CLA] Editor Image duplicate display on FF when viewSouce plugin acted

[youngho]

At the Firefox, When viewSource plugin activated and than double clicked the image in the editArea, the image show duplicated.

I make the test page at the jsfiddle.

​https://jsfiddle.net/youngho/eh9rg33p/1/

Here is the patch.

Index: ViewSource?.js ===================================================================

@@ -182,7 +182,7 @@

just set sizes equal this.sourceArea.style.height = ed.iframe.style.height; this.sourceArea.style.width = ed.iframe.style.width;

- domStyle.set(ed.iframe, "display", "none"); + domStyle.set(ed.iframe, "height", 0);

domStyle.set(this.sourceArea, {

display: "block"

});

@@ -274,7 +274,7 @@

});

domStyle.set(this.sourceArea, "display", "none");

- domStyle.set(ed.iframe, "display", "block"); + domStyle.set(ed.iframe, "height", this.sourceArea.style.height);

delete ed._sourceQueryCommandEnabled;

[bill]

simplified test case

[bill]

OK, that works for FF and chrome, but on IE10 the <iframe> isn't completely hidden as the image still leaks through. I'll attach a screenshot.

[bill]

problem setting height:0 and IE10: image still visible

[Bill Keese <[email protected]…>]

In 96bd828e5756f7f1f7408d2d05e7b538fde155df/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?