Opened 5 years ago

Closed 4 years ago

#18607 closed defect (fixed)

[PATCH][CLA] Editor Image duplicate display on FF when viewSouce plugin acted

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.11
Component: Editor Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

At the Firefox, When viewSource plugin activated and than double clicked the image in the editArea, the image show duplicated.

I make the test page at the jsfiddle.

https://jsfiddle.net/youngho/eh9rg33p/1/

Here is the patch.

Index: ViewSource?.js ===================================================================

@@ -182,7 +182,7 @@

just set sizes equal this.sourceArea.style.height = ed.iframe.style.height; this.sourceArea.style.width = ed.iframe.style.width;


- domStyle.set(ed.iframe, "display", "none"); + domStyle.set(ed.iframe, "height", 0);

domStyle.set(this.sourceArea, {

display: "block"

});

@@ -274,7 +274,7 @@

});

domStyle.set(this.sourceArea, "display", "none");


- domStyle.set(ed.iframe, "display", "block"); + domStyle.set(ed.iframe, "height", this.sourceArea.style.height);

delete ed._sourceQueryCommandEnabled;

Attachments (2)

editor.html (914 bytes) - added by bill 4 years ago.
simplified test case
Screen Shot 2015-06-25 at 7.10.36 PM.gif (50.6 KB) - added by bill 4 years ago.
problem setting height:0 and IE10: image still visible

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.11
Priority: undecidedhigh

Changed 4 years ago by bill

Attachment: editor.html added

simplified test case

comment:2 Changed 4 years ago by bill

OK, that works for FF and chrome, but on IE10 the <iframe> isn't completely hidden as the image still leaks through. I'll attach a screenshot.

Changed 4 years ago by bill

problem setting height:0 and IE10: image still visible

comment:3 Changed 4 years ago by bill

Owner: set to bill
Status: newassigned

comment:4 Changed 4 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 96bd828e5756f7f1f7408d2d05e7b538fde155df/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.