Opened 6 years ago
Closed 6 years ago
#18607 closed defect (fixed)
[PATCH][CLA] Editor Image duplicate display on FF when viewSouce plugin acted
Reported by: | youngho | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.11 |
Component: | Editor | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
At the Firefox, When viewSource plugin activated and than double clicked the image in the editArea, the image show duplicated.
I make the test page at the jsfiddle.
https://jsfiddle.net/youngho/eh9rg33p/1/
Here is the patch.
Index: ViewSource?.js ===================================================================
@@ -182,7 +182,7 @@
just set sizes equal this.sourceArea.style.height = ed.iframe.style.height; this.sourceArea.style.width = ed.iframe.style.width;
- domStyle.set(ed.iframe, "display", "none");
+ domStyle.set(ed.iframe, "height", 0);
domStyle.set(this.sourceArea, {
display: "block"
});
@@ -274,7 +274,7 @@
});
domStyle.set(this.sourceArea, "display", "none");
- domStyle.set(ed.iframe, "display", "block");
+ domStyle.set(ed.iframe, "height", this.sourceArea.style.height);
delete ed._sourceQueryCommandEnabled;
Attachments (2)
Change History (6)
comment:1 Changed 6 years ago by
Milestone: | tbd → 1.11 |
---|---|
Priority: | undecided → high |
Changed 6 years ago by
Attachment: | editor.html added |
---|
comment:2 Changed 6 years ago by
OK, that works for FF and chrome, but on IE10 the <iframe> isn't completely hidden as the image still leaks through. I'll attach a screenshot.
Changed 6 years ago by
Attachment: | Screen Shot 2015-06-25 at 7.10.36 PM.gif added |
---|
problem setting height:0 and IE10: image still visible
comment:3 Changed 6 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
comment:4 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
simplified test case