Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#186 closed defect (fixed)

found bug in dojo.dnd.HtmlDragManager, fix included

Reported by: rogers_reilly@… Owned by: anonymous
Priority: high Milestone:
Component: General Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

Bug: drop and drag code (which is great, btw, just started using dojo) does not correctly detect drop area when screen is scrolled. you can see it here by forcing a right scrollbar and hover-dragging between lists ... the Manager mistakes the moused-over child node by the screen offset: http://archive.dojotoolkit.org/dojo-2005-11-05/tests/dnd/test_simple.html

Fix: in HtmlDragManager?.js (in nightly build, http://archive.dojotoolkit.org/dojo-2005-11-05/src/dnd/), lines 205 and 206 need to change as follows:

currently: 205 var ttx = dojo.style.getAbsoluteX(tn); 206 var tty = dojo.style.getAbsoluteY(tn);

should be: 205 var ttx = dojo.style.getAbsoluteX(tn, true); 206 var tty = dojo.style.getAbsoluteY(tn, true);

second param is includeScroll, which the code is currently assuming to be false.

thanks for a great-looking project.

Change History (2)

comment:1 Changed 14 years ago by alex

Milestone: 0.2release
Resolution: fixed
Status: newclosed

this looks to be fixed as of some recent version. Marking as such.

comment:2 Changed 13 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.