Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18591 closed defect (fixed)

CheckBox: (incorrectly) sets both disabled and aria-disabled

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.9.8
Component: Dijit Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

Calling set("disabled", true) on a dijit checkbox, sets both a disabled and aria-disabled attribute on the focus element. This leads to the following RPT (http://www-03.ibm.com/able/news/WAI_ARIAatIBM.html) violation:

Use the HTML5 attribute OR the associated WAI-ARIA attribute (not both) on any one input element. CI162 Checkpoint 3.3b

The particular code is in _FormWidgetMixin:

_setDisabledAttr: function(/*Boolean*/ value){
            this._set("disabled", value);
            domAttr.set(this.focusNode, 'disabled', value);
            if(this.valueNode){
                domAttr.set(this.valueNode, 'disabled', value);
            }
            this.focusNode.setAttribute("aria-disabled", value ? "true" : "false");

Change History (4)

comment:1 Changed 5 years ago by bill

Milestone: tbd1.9.8
Status: newassigned

_FormWidgetMixin sets both disabled and aria-disabled to handle both when this.focusNode is an <input>, and when it's a plain <span>. So it should be changed to set one or the other, depending on the type of this.focusNode.

comment:2 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In bdb32819bfc8467a903f50562c07fd6d2001aa70/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 5 years ago by Bill Keese <bill@…>

In 0908dc6fd7231bf3ad32073a372529ea49761f18/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Bill Keese <bill@…>

In b598eea613336da546c27ad5d617589cf8953648/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.