Opened 5 years ago

Last modified 2 years ago

#18587 assigned defect

[patch][needs test] JS Error during load of iframe with style "display:none" in Firefox

Reported by: tweb-ix Owned by: dylan
Priority: high Milestone: 1.14
Component: HTML Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

During load of an iframe with "display:none" a js error occurs cause getComputedStyle returns null for elements in this iframe.

Error occurs in dojo/hccss.js line 32

Following change in dojo/dom-style.js line 49 fix the problem:

- node.ownerDocument.defaultView.getComputedStyle(node, null) || {} : {};
+ (node.ownerDocument.defaultView.getComputedStyle(node, null) || {}) : {};

Change History (7)

comment:1 Changed 5 years ago by tweb-ix

corrected fix:

- node.ownerDocument.defaultView.getComputedStyle(node, null) : {};
+ (node.ownerDocument.defaultView.getComputedStyle(node, null) || {}) : {};

comment:2 Changed 5 years ago by bill

Component: GeneralHTML
Owner: set to Eugene Lazutkin

comment:3 Changed 4 years ago by dylan

Milestone: tbd1.11
Owner: changed from Eugene Lazutkin to dylan
Status: newassigned

comment:4 Changed 4 years ago by dylan

Priority: undecidedhigh
Summary: JS Error during load of iframe with style "display:none" in Firefox[patch][needs test] JS Error during load of iframe with style "display:none" in Firefox

comment:5 Changed 4 years ago by dylan

Milestone: 1.111.12

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

comment:6 Changed 3 years ago by dylan

Milestone: 1.121.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:7 Changed 2 years ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.