Opened 5 years ago

Closed 5 years ago

#18544 closed defect (fixed)

Fix dojo/request/xhr not to use event property "position"

Reported by: Gavin R Owned by:
Priority: undecided Milestone: 1.10.5
Component: Core Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

When making an XHR request, Chrome gives a warning: 

The XMLHttpRequest progress event property 'position' is deprecated. Please use 'loaded' instead.

I believe this has to do with this line: ​https://github.com/dojo/dojo/blob/1.10.4/request/xhr.js#L118

Chrome's deprication: ​https://groups.google.com/a/chromium.org/forum/#!topic/blink-checkins/IHxYBwuwBL4

Simplified test case: ​http://jsbin.com/semoreduyi/3/edit?html,js,output

I don't know if this is a fix that needs to go into Dojo, though, since it seems to be only affecting Chrome (for now). If I can get a confirmation from the team that this seems to be a reasonable change, I'd be happy to submit a PR.

Thanks!

Attachments (1)

test-case.PNG​ (79.6 KB) - added by Gavin R 5 years ago.
test case in chrome

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Gavin R

Attachment: test-case.PNG​ added

test case in chrome

comment:1 Changed 5 years ago by Gavin R

Updated test case to point to file that exists: ​http://jsbin.com/zakiri/1/edit?html,js,output

comment:2 Changed 5 years ago by dylan

Milestone: tbd → 1.11

comment:4 Changed 5 years ago by dylan

Milestone: 1.11 → 1.10.5
Resolution: → fixed
Status: new → closed

Fixed in ​https://github.com/dojo/dojo/commit/d400e28ad88aca5a3244710ad2ac1d341868d3d7 , backported to 1.10 ( ​https://github.com/dojo/dojo/commit/877cfa63bcd097a7d020dd87b7fdfc28b41337a2 )

Note: See TracTickets for help on using tickets.