Opened 5 years ago

Closed 3 years ago

#18536 closed enhancement (fixed)

[meta] Add new flat theme to 1.11

Reported by: dylan Owned by: dylan
Priority: high Milestone: 1.11
Component: themes Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

We're working with https://yiweima.github.io/flatdojo/ to add this theme to Dojo 1.11

The original committer is currently working through my feedback on how to clean up the directory structure and theme itself, licensing, etc.

Plan is to add it to https://github.com/dojo/themes , then update our release system to add the new themes package.

We may also add https://github.com/kfranqueiro/dijit-claro-stylus to the same repo.

Change History (10)

comment:1 Changed 5 years ago by bill

Owner: changed from nonken to dylan
Status: newassigned

comment:3 Changed 4 years ago by dylans <dylan@…>

In 78e264e9f16aff5e250cb1467e52f44c9e151685/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 4 years ago by dylan

Added a pull request for dgrid flat, https://github.com/dojo/themes/pull/14 . Need to determine what the path should be to reference dgrid/css/skins/skin.styl.

comment:5 Changed 4 years ago by dylan

Summary: Add new flat theme to 1.11[meta] Add new flat theme to 1.11

comment:6 Changed 4 years ago by dylan

Resolution: fixed
Status: assignedclosed

Landed dgrid flat theme as https://github.com/dojo/themes/commit/3fb4714c24eb56a16f44da716d7c57d44edac709 .

Closing this ticket as complete. There are improvements that can still be made via the todos, but this is ready for 1.11 now.

comment:7 Changed 3 years ago by Dylan Schiemann <dylan@…>

In c0e3782/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 3 years ago by bsnelderwaard

This latest fix causes our dojo builds to fail with lots of messages like "error(311) Missing dependency. module: ...; dependency: themes". Is this expected? Is the themes package obligatory now?

comment:9 Changed 3 years ago by dylan

Resolution: fixed
Status: closedreopened

Sigh, ok, I'll revert and revisit it.

comment:10 Changed 3 years ago by dylan

Resolution: fixed
Status: reopenedclosed

Reverted the offending fixedScopeMap change in master.

I still need to solve the problem though, which is that it is needed to run builds that include the themes efficiently. I'll open a separate ticket for that.

Note: See TracTickets for help on using tickets.