Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18533 closed defect (invalid)

dojox/lang/functiona/zip.jz and curry.js broken in 1.10.4

Reported by: Arunas Ruksnaitis Owned by: Arunas Ruksnaitis
Priority: low Milestone: 1.11
Component: Dojox Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

dojo.provide is still used, but no longer defined.

Attachments (2)

fixed.tgz (1.7 KB) - added by Arunas Ruksnaitis 5 years ago.
Fixed sources
fix2.tar.gz (1.6 KB) - added by Arunas Ruksnaitis 5 years ago.
New fix

Download all attachments as: .zip

Change History (15)

comment:1 Changed 5 years ago by bill

Owner: changed from Adam Peller to Arunas Ruksnaitis
Status: newpending

dojo.provide() is still supported (although it's deprecated in favor of AMD). What makes you think that it's not defined?

comment:2 Changed 5 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

comment:3 Changed 5 years ago by Arunas Ruksnaitis

I have downloaded dojo 1.10.4 source for debugging purposes and pointed my application to the new unmodified dojo source. The application that worked happily on dojo 1.10.1 release version stopped working, the browser complaining about undefined "dojo.provide" in the said files ("undefined is not a function", it said).

I edited the files in question in AMD style (attached) to make my application work again.

I have not researched what broke this dependency on dojo.provide, maybe file inclusion order changes or something. I think the easiest way is to just convert the files to AMD.

Changed 5 years ago by Arunas Ruksnaitis

Attachment: fixed.tgz added

Fixed sources

comment:4 in reply to:  1 Changed 5 years ago by Arunas Ruksnaitis

Replying to bill:

dojo.provide() is still supported (although it's deprecated in favor of AMD). What makes you think that it's not defined?

Just updated the ticket and provided the fixed files. I think it is easier that investigating what is broken in 1.10.4, but I could spend some (limited) time to create a broken test case.

comment:5 Changed 5 years ago by bill

OK, maybe that's better. Thanks for the conversion. But before taking your fixes..

  1. You would need to sign the CLA (http://dojofoundation.org/about/cla).
  2. We take patches now via github pull requests.
  3. You are referencing dojo.mixin() without listing dojo/_base/lang as a dependency. (And you should reference lang.mixin() not dojo.mixin().)

comment:6 Changed 5 years ago by Arunas Ruksnaitis

Thanks bill. Understand about lang.mixin - I just made minimal edits to make it work. Please explain what you want me to do in terms of github.

comment:7 Changed 5 years ago by bill

OK thanks. About github, see https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md#submitting-a-pull-request. (If you are unfamiliar with github or pull requests in general I'm sure google will give some more basic explanation.)

comment:8 Changed 5 years ago by Arunas Ruksnaitis

Signed CLA, created github account (arunasr), forked the dojo/dojox repository, can't clone the repository locally (permission denied).

I have limited time for all of this, please help me out with sharing my fixes; alternatively I shall keep my changes to myself.

New fixes attached, this time in line with other dojox/lang/functional.

Last edited 5 years ago by Arunas Ruksnaitis (previous) (diff)

Changed 5 years ago by Arunas Ruksnaitis

Attachment: fix2.tar.gz added

New fix

comment:9 Changed 5 years ago by Arunas Ruksnaitis

Had a wrong pull URL before. Pull request submitted.

comment:10 Changed 5 years ago by bill

Yup, I see https://github.com/dojo/dojox/pull/174, thanks, it looks good to me. Dylan said he would commit it.

comment:11 Changed 5 years ago by dylans <dylan@…>

In 7adb0264724b89c762f9f9a670e20f155dfd51ae/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:12 Changed 5 years ago by dylan

Milestone: tbd1.11
Priority: undecidedlow

Did not backport at this time as it's not really a bug fix but an update to AMD.

comment:13 Changed 5 years ago by Arunas Ruksnaitis

I might argue about "not really a bug" - it worked in 1.10.1 and is broken in 1.10.4.

This change is a remedy for missing "dojo.provide" at the time of loading the files. It may be a symptom, but if this is "just an update to AMD", then I think the disappearance of "dojo.provide" needs to be investigated.

Note: See TracTickets for help on using tickets.