Opened 4 years ago

Last modified 2 years ago

#18523 new defect

Test for hrefTarget in dojox.mobile._ItemBase is incorrect and fails

Reported by: PeterRook Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.14
Component: DojoX Mobile Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

When I set href in a ListItem? to an external website without setting hrefTarget the test in line 295 returns false causing the href not to be opened. When I set the hrefTarget to "_blank" it works OK. This is because the default hrefTarget ("") is evaluated to false (in IE11). I think a better default would be "_blank"

if (this.href && this.hrefTarget && this.hrefTarget != "_self") {

win.global.open(this.href, this.hrefTarget
"_blank");

this._onNewWindowOpened(e); return;

}

Change History (3)

comment:1 Changed 4 years ago by dylan

Looks like a fairly simple fix if someone wants to tackle this.

@PeterRook?, care to submit a pull request per the guidelines at https://github.com/dojo/dojox/blob/master/CONTRIBUTING.md ?

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.12

comment:3 Changed 2 years ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.