Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#1852 closed defect (fixed)

IE 5.5 out of stack space error on dojo.widget.Dialog

Reported by: jthorhauer@… Owned by: alex
Priority: high Milestone: 0.9
Component: Widgets Version: 0.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When using IE 5.5 I will get the following error when loading dojo.widget.Dialog on a pge that has many nested tables:

Line 876 Error: Out of stack space

The actual line that it is referring to is in on line 91 of src/widget/Parse.js. It is:

comps = comps.concat(this.createComponents(frag, parentComp));

The problem can be fixed if I replace the above line with the following:


                                if((frag)&&(frag["tagName"])&&(frag!=frag["nodeRef"]))
                                {

                                  comps = comps.concat(this.createComponents(frag, parentComp));
                                }
                                else
                                {
                                   comps = comps.concat(this.createSubComponents(frag, parentComp));
                                }

Here is a diff"

diff Parse.js Parse.js.fixed
91c91,100
<                               comps = comps.concat(this.createComponents(frag, parentComp));
---
>
>                                 if((frag)&&(frag["tagName"])&&(frag!=frag["nodeRef"]))
>                                 {
>
>                                   comps = comps.concat(this.createComponents(frag, parentComp));
>                                 }
>                                 else
>                                 {
>                                    comps = comps.concat(this.createSubComponents(frag, parentComp));
>                                 }

Change History (5)

comment:1 Changed 13 years ago by bill

Milestone: 0.5
Owner: changed from bill to alex

comment:2 Changed 13 years ago by Adam Peller

see #1124

comment:3 Changed 13 years ago by bill

Resolution: fixed
Status: newclosed

IE5.5 no longer supported and also, the new dijit architecture has fixed this problem I think. Reopen if problem occurs w/dojo 0.9 and IE6.0 or IE7.0 (IE5.5 is no longer supported)

comment:4 Changed 8 years ago by bill

In [26471]:

Speed up ColorPalette creation time:

(1) Put ondijitclick handler on the TABLE node rather than each TD.

(2) Use :hover and :active CSS pseudo-selectors rather than setting dijitPaletteCellHover / dijitPaletteCellActive. Needed to increase selectivity of dijitPaletteCellSelected selector so it wins over dijitPaletteCell:hover selector. (Hovering the selected cell should have no effect, since clicking that cell has no effect.) Note that hover state is no longer shown on IE6, but works on IE7+. Could add code to make IE work (monitoring mouseout, mouseover, mousedown, mouseup on this.gridNode) but I don't think it's worth the code bloat.

Fixes #1852 !strict.

comment:5 Changed 8 years ago by bill

Description: modified (diff)

Oops, above check in was for #13852, not this ticket.

Last edited 8 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.