Opened 6 years ago

Last modified 5 years ago

#18513 closed defect

PasswordValidator Required attribute not fully working — at Version 5

Reported by: Daniel Owned by: dylan
Priority: undecided Milestone: 1.8.11
Component: DojoX Form Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dylan)

The required attribute of dojox.form.ValidationPassword? is not working correctly as we cannot use widget.set('required', true/false).

Two fixes need to be done to the source code: 1) the function '_setRequiredAttribute' should be renamed to '_setRequiredAttr' 2) the call to the this._refreshState() function should be removed (as this is automatically called by the parent set() function)

Change History (5)

comment:1 Changed 6 years ago by bill

Component: GeneralDojoX Form
Owner: set to dante

I assume you are talking about PasswordValidator?? Your changes sound reasonable. If you'd like to submit a CLA and then submit a PR for the change, that would be great. I notice there's already a test_PasswordValidator.html file but not sure if it checks this case.

comment:2 Changed 6 years ago by Daniel

Yes, I am talking about dojox/form/PasswordValidator I am not sure what you mean by 'submit a CLA' and 'submit a PR'. I can make a patch for dojo version 1.10 if this can help.

comment:3 Changed 6 years ago by bill

Well, I meant that before we can accept any non-trivial patch we need a CLA ( from either you or your company, and that patches are preferably submitted as github pull requests (

comment:4 Changed 6 years ago by dylan explains how to contribute, in case that helps.

But if it's too much, then just file a CLA and a patch, and we'll look at it.

A pull request via GitHub? is the best way for us to attribute the contribution to you.

comment:5 Changed 5 years ago by dylan

Description: modified (diff)
Milestone: tbd1.11
Owner: changed from dante to dylan
Status: newassigned
Summary: ValidationPassword Required attribute not fully workingPasswordValidator Required attribute not fully working

Pull request added at , in case anyone wants to test it.

Note: See TracTickets for help on using tickets.