Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#18513 closed defect (fixed)

PasswordValidator Required attribute not fully working

Reported by: Daniel Owned by: dylan
Priority: undecided Milestone: 1.8.11
Component: DojoX Form Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dylan)

The required attribute of dojox.form.ValidationPassword? is not working correctly as we cannot use widget.set('required', true/false).

Two fixes need to be done to the source code: 1) the function '_setRequiredAttribute' should be renamed to '_setRequiredAttr' 2) the call to the this._refreshState() function should be removed (as this is automatically called by the parent set() function)

Change History (10)

comment:1 Changed 5 years ago by bill

Component: GeneralDojoX Form
Owner: set to dante

I assume you are talking about PasswordValidator?? Your changes sound reasonable. If you'd like to submit a CLA and then submit a PR for the change, that would be great. I notice there's already a test_PasswordValidator.html file but not sure if it checks this case.

comment:2 Changed 5 years ago by Daniel

Yes, I am talking about dojox/form/PasswordValidator I am not sure what you mean by 'submit a CLA' and 'submit a PR'. I can make a patch for dojo version 1.10 if this can help.

comment:3 Changed 5 years ago by bill

Well, I meant that before we can accept any non-trivial patch we need a CLA (http://dojofoundation.org/about/cla) from either you or your company, and that patches are preferably submitted as github pull requests (https://help.github.com/articles/using-pull-requests/).

comment:4 Changed 5 years ago by dylan

https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md explains how to contribute, in case that helps.

But if it's too much, then just file a CLA and a patch, and we'll look at it.

A pull request via GitHub? is the best way for us to attribute the contribution to you.

comment:5 Changed 4 years ago by dylan

Description: modified (diff)
Milestone: tbd1.11
Owner: changed from dante to dylan
Status: newassigned
Summary: ValidationPassword Required attribute not fully workingPasswordValidator Required attribute not fully working

Pull request added at https://github.com/dojo/dojox/pull/190 , in case anyone wants to test it.

comment:6 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In b05335a320e3bfc60cf44af70670754056cc5013/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 4 years ago by dylans <dylan@…>

In d937015210630fef2ac8a4f17d79b8921a89001b/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 4 years ago by dylans <dylan@…>

In 3233adb85d367cb606b261d13f7a1c667e5c7bff/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 4 years ago by dylans <dylan@…>

In 142fe1b98c90e2fa839d8cd96d024c0060d82cb7/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 4 years ago by dylan

Milestone: 1.111.8.11
Note: See TracTickets for help on using tickets.