#18513 closed defect (fixed)
PasswordValidator Required attribute not fully working
| Reported by: | Daniel | Owned by: | dylan |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8.11 |
| Component: | DojoX Form | Version: | 1.10.4 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
The required attribute of dojox.form.ValidationPassword? is not working correctly as we cannot use widget.set('required', true/false).
Two fixes need to be done to the source code: 1) the function '_setRequiredAttribute' should be renamed to '_setRequiredAttr' 2) the call to the this._refreshState() function should be removed (as this is automatically called by the parent set() function)
Change History (10)
comment:1 Changed 5 years ago by
| Component: | General → DojoX Form |
|---|---|
| Owner: | set to dante |
comment:2 Changed 5 years ago by
Yes, I am talking about dojox/form/PasswordValidator I am not sure what you mean by 'submit a CLA' and 'submit a PR'. I can make a patch for dojo version 1.10 if this can help.
comment:3 Changed 5 years ago by
Well, I meant that before we can accept any non-trivial patch we need a CLA (http://dojofoundation.org/about/cla) from either you or your company, and that patches are preferably submitted as github pull requests (https://help.github.com/articles/using-pull-requests/).
comment:4 Changed 5 years ago by
https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md explains how to contribute, in case that helps.
But if it's too much, then just file a CLA and a patch, and we'll look at it.
A pull request via GitHub? is the best way for us to attribute the contribution to you.
comment:5 Changed 5 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | tbd → 1.11 |
| Owner: | changed from dante to dylan |
| Status: | new → assigned |
| Summary: | ValidationPassword Required attribute not fully working → PasswordValidator Required attribute not fully working |
Pull request added at https://github.com/dojo/dojox/pull/190 , in case anyone wants to test it.
comment:6 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:10 Changed 5 years ago by
| Milestone: | 1.11 → 1.8.11 |
|---|
I assume you are talking about PasswordValidator?? Your changes sound reasonable. If you'd like to submit a CLA and then submit a PR for the change, that would be great. I notice there's already a test_PasswordValidator.html file but not sure if it checks this case.