#18511 closed defect (fixed)
[patch] dijit/popup: sticky vertical scrollbar
Reported by: | Jason Cowley | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9.8 |
Component: | Dijit | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This occurs in all versions of IE.
- Open the attached test page in IE. The page consists of a dijit/form/FilteringSelect widget.
- Make sure you have a "tall" browser window and click the drop-down button to display the full list of items. You should not see a vertical scroll bar. Close the drop-down.
- Shrink the browser window so that the full list of items can't be displayed and click the drop-down. You should see the list of items with a vertical scrollbar. Close the drop-down.
- Grow the browser window so the full list of items should fit again and click the drop-down.
Expected: Full list of items displayed with no vertical scroll bar Actual: Full list of items display with vertical scroll bar
Does not happen on other browsers.
Will attach test page and patch.
Attachments (2)
Change History (8)
Changed 6 years ago by
comment:1 Changed 5 years ago by
Milestone: | tbd → 1.11 |
---|---|
Summary: | dijit/popup: sticky vertical scrollbar → [patch] dijit/popup: sticky vertical scrollbar |
Looks like a simple fix, may want to consider for 1.11.
comment:2 Changed 5 years ago by
@bill, want to consider this one? It has a test and a one line patch (to set overflow-y). The patch itself is trivial so it can probably be accepted without a CLA, though I'll ask for one.
@jcowley, can you file a CLA when you get a chance? http://dojofoundation.org/about/claForm
comment:3 Changed 5 years ago by
Milestone: | 1.11 → 1.9.8 |
---|---|
Status: | new → assigned |
Thanks for the fix. Sure, I'll check this in, and backport. Looks like setting overflow
is unnecessary. Since open()
sets overflowY
, hide()
should do the same.
Note that there's no automated test because it's too hard to change the viewport size from doh/robot (or for that matter from webdriver).
comment:4 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Test page to reproduce bug