#18491 closed defect (fixed)
dojox/widget/Toaster is leaking when using messageTopic
Reported by: | tanneman | Owned by: | dante |
---|---|---|---|
Priority: | undecided | Milestone: | 1.11 |
Component: | DojoX Widgets | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Found in version 1.10.4 Open the file dojox/widget/Toaster
See line 82
the connect.subscribe()
should be wrapped with a this.own()
in order to make sure the subscription is removed when the widget is destroyed.
So it should read:
this.own(connect.subscribe(this.messageTopic, this, "_handleMessage"));
Change History (4)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
Started working on cleaning this code up to use more modern best practices. It's a bit more involved than expected, but I'm most of the way done, see https://github.com/dojo/dojox/pull/192
comment:3 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed 6 years ago by
Milestone: | tbd → 1.11 |
---|
Does not cleanly backport, so leaving as 1.11.
Note: See
TracTickets for help on using
tickets.
Makes sense, or alternately this presumably works: