dojox/widget/Toaster is leaking when using messageTopic

[tanneman]

Found in version 1.10.4 Open the file dojox/widget/Toaster

See line 82 the connect.subscribe() should be wrapped with a this.own() in order to make sure the subscription is removed when the widget is destroyed.

So it should read:

this.own(connect.subscribe(this.messageTopic, this, "_handleMessage"));

[bill]

Makes sense, or alternately this presumably works:

this.subscribe(this.messageTopic, "_handleMessage");

[dylan]

Started working on cleaning this code up to use more modern best practices. It's a bit more involved than expected, but I'm most of the way done, see ​https://github.com/dojo/dojox/pull/192

[dylans <[email protected]…>]

In 56ee55d6b240de0b921f4ec200bd3e08951cbdcc/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[dylan]

Does not cleanly backport, so leaving as 1.11.