Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18467 closed defect (fixed)

Cut/Copy/Paste in Editor Widget on Firefox no longer giving the message to use the keyboard.

Reported by: Ed Chatelain Owned by: Ed Chatelain
Priority: undecided Milestone: 1.6.4
Component: Editor Version: 1.10.4
Keywords: Cc:
Blocked By: Blocking:

Description

It looks like the error code coming back from FireFox? has changed, I am on V32, but I was told V31 and V34 are also failing. FireFox? is now returning a SecurityError? with code 18 where it used to return a service denied code 1011. I have not found anything saying why FireFox? made the change, but it would be easy to add the check for e.code == 18 in Editor._clipboardCommand().

Change History (8)

comment:1 Changed 5 years ago by Ed Chatelain

Owner: set to Ed Chatelain
Status: newassigned

There is a TODO: in the dijit/Editor.js code (https://github.com/dojo/dijit/blob/master/Editor.js#L425) asking: TODO: when else might we get an exception? Do we need the Mozilla test below?

It is checking for the code 1011, but now FF is returning code 18. I can either add another check for 18, or remove all of the checks for specific codes. It seems to me that we should not be checking for the specific error code, if we catch an exception don't we know that the cut/copy/paste did not work, and that they should use the keyboard to do it.

I think we should remove the check for the specific codes, and always show the message if we catch an exception. Any objections?

comment:2 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

Resolution: fixed
Status: assignedclosed

In d9396ec8442ea94d65b70d24a866bd43d62c6539/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In b317f48c54bf8b1502680b8c7d48575f1d88f66a/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In f9094f93c2d29936fca43f3d705f2f65d2d8cd33/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 2d98197c34ac9b65c90f23699f31ec8186fd72c8/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 03702b0369979b00871a5bcd3a99e043aa24feb5/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Last edited 5 years ago by Ed Chatelain (previous) (diff)

comment:7 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 52864f5e61a76bf40f6bd94d1202724aaed20043/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Ed Chatelain

Milestone: tbd1.6.4
Note: See TracTickets for help on using tickets.