Opened 5 years ago

Closed 5 years ago

#18463 closed defect (fixed)

dojox/rpc/Rest is leaking an "index" global in 1.6.x build.

Reported by: Clement Mathieu Owned by: Clement Mathieu
Priority: high Milestone: 1.6.4
Component: Dojox Version: 1.6.3
Keywords: Cc:
Blocked By: Blocking:

Description

When built with 1.6.x, dojox/rpc/Rest code is transformed to something like:

if(!dojo._hasResource["dojox.rpc.Rest"]){ 
dojo._hasResource["dojox.rpc.Rest"] = true;
dojo.provide("dojox.rpc.Rest");
	function index(deferred, service, range, id){
		...
	}
	drr = dojox.rpc.Rest = function(...){
		...
	};
}


Which creates a global index function.

I would suggest to wrap this module's code inside a function (like it was in 1.5.x) to prevent this.

Change History (4)

comment:1 Changed 5 years ago by cjolif

Milestone: tbd1.6.4
Priority: undecidedhigh

yes the "AMD"-like wrappers in 1.6 give people the feeling there is a scope but there is not once the build is performed.

comment:2 Changed 5 years ago by cjolif

Owner: changed from Adam Peller to Clement Mathieu
Status: newassigned

comment:3 Changed 5 years ago by Clement Mathieu

I opened a PR with a candidate fix for this issue. https://github.com/dojo/dojox/pull/164

comment:4 Changed 5 years ago by Christophe Jolif <cjolif@…>

Resolution: fixed
Status: assignedclosed

In 1a0d6a87f3c304e207ec66e2c2e677841686c576/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.