Opened 6 years ago
Closed 6 years ago
#18463 closed defect (fixed)
dojox/rpc/Rest is leaking an "index" global in 1.6.x build.
Reported by: | Clement Mathieu | Owned by: | Clement Mathieu |
---|---|---|---|
Priority: | high | Milestone: | 1.6.4 |
Component: | Dojox | Version: | 1.6.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
When built with 1.6.x, dojox/rpc/Rest code is transformed to something like:
if(!dojo._hasResource["dojox.rpc.Rest"]){ dojo._hasResource["dojox.rpc.Rest"] = true; dojo.provide("dojox.rpc.Rest"); function index(deferred, service, range, id){ ... } drr = dojox.rpc.Rest = function(...){ ... }; }
Which creates a global index function.
I would suggest to wrap this module's code inside a function (like it was in 1.5.x) to prevent this.
Change History (4)
comment:1 Changed 6 years ago by
Milestone: | tbd → 1.6.4 |
---|---|
Priority: | undecided → high |
comment:2 Changed 6 years ago by
Owner: | changed from Adam Peller to Clement Mathieu |
---|---|
Status: | new → assigned |
comment:3 Changed 6 years ago by
I opened a PR with a candidate fix for this issue. https://github.com/dojo/dojox/pull/164
comment:4 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
yes the "AMD"-like wrappers in 1.6 give people the feeling there is a scope but there is not once the build is performed.