Opened 13 years ago

Closed 13 years ago

#1845 closed defect (worksforme)

TitlePane, after calling wipeIn, expanding inside content will overflow containerNode div

Reported by: ivangaravito@… Owned by: anonymous
Priority: high Milestone:
Component: General Version: 0.4
Keywords: wipeIn Cc:
Blocked By: Blocking:

Description

Using Dojo v0.4.0, conditions for bug:

  • FF 1.5.0.6

Close and open a TitlePane? widget

When a TitlePane? is open (calling the dojo.html.lfx.wipeIn function), the containerNode's height is set to the "box height". This causes the content to overflow the DIV tag. It is visible when you have nested TitlePanes?.

Im not a javascript xpert, I suppose dojo.html.lfx.wipeIn function should restore the original height value, but if old value is undefined or not valid, then the height value will not be restored, keeping the final value of dojo.html.lfx.propertyAnimation function!!

Attachments (1)

titlepane-v040.html (1.8 KB) - added by ivangaravito@… 13 years ago.
Sample file of how TitlePane?'s contents overflows after calling wipeIn

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by ivangaravito@…

Attachment: titlepane-v040.html added

Sample file of how TitlePane?'s contents overflows after calling wipeIn

comment:1 Changed 13 years ago by ivangaravito@…

I resolved it changing TitlePane?.js this way:

By Ivan Garavito Garcia (ivangaravito@…), 07/NOV/2006 _fixHeight: "", Allows keep containerNode's height

onLabelClick: function() {

if (this.open) {

dojo.lfx.wipeOut(this.containerNode, 250).play(); this.open=false;

} else {

By Ivan Garavito Garcia (ivangaravito@…), 07/NOV/2006 this._fixHeight = this.containerNode.style.height; Saves current height dojo.lfx.wipeIn(this.containerNode, 250, null, this.onWipedIn).play(); Call me when animation finish this.open=true;

}

},

By Ivan Garavito Garcia (ivangaravito@…), 07/NOV/2006 Callback function when wipeIn animation ends onWipedIn: function(node, anim) {

Returns original height. If not previously specified, then assigns 'auto' value. node.style.height = (this._fixHeight&&this._fixHeight!=""? this._fixHeight: "auto");

},

comment:2 Changed 13 years ago by bill

Resolution: worksforme
Status: newclosed

I've tried your testcase again firefox 1.5.0.8 on windows (that's the latest version; I can't get version 1.5.0.6), and against the latest dojo in the 0.4.1 branch. I clicked "Child 1" and "click me for details" repeatedly. Everything seems fine.

If you can reproduce the bug with the latest code against the newest firefox please let us know.

Note: See TracTickets for help on using tickets.