Opened 4 years ago

Last modified 20 months ago

#18444 new defect

dojo/dom-style::get() doesn't return thicknesses as number

Reported by: Michael J Van Sickle Owned by: Eugene Lazutkin
Priority: undecided Milestone: 1.14
Component: HTML Version: 1.10.3
Keywords: Cc:
Blocked By: Blocking:

Description

dom-style's get() method seems designed to try to find styles that are measurements and return the value as a number representing the value in pixels. The regex that looks for these values does not include "thickness", as in "borderThickness" and, as a result, those values are returned as raw measurements.

e.g. var node = document.createElement("div"); node.style.borderThickness = "42px";

var result = domStyle.get(node, "borderThickness");

result is expected to be 42, but is '42px'.

ref: https://github.com/dojo/dojo/blob/master/dom-style.js#L198

Change History (5)

comment:1 Changed 4 years ago by bill

Component: GeneralHTML
Owner: set to Eugene Lazutkin

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.11

comment:3 Changed 3 years ago by dylan

Milestone: 1.111.12

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

comment:4 Changed 3 years ago by dylan

Milestone: 1.121.13

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

comment:5 Changed 20 months ago by dylan

Milestone: 1.131.14
Note: See TracTickets for help on using tickets.