Opened 5 years ago

Closed 4 years ago

#18439 closed enhancement (patchwelcome)

Need Dojo Object Store for localStorage

Reported by: Akira Sudoh Owned by: Akira Sudoh
Priority: undecided Milestone: tbd
Component: Data Version: 1.10.3
Keywords: Cc:
Blocked By: Blocking:

Description

As far as I see there is no Dojo Object Store implementation for localStorage (though there is one for IndexedDB, dojox/store/LocalDB). A discussion here: https://github.com/tastejs/todomvc/pull/1101/files#r22573915

Change History (4)

comment:1 Changed 5 years ago by bill

Component: GeneralData
Owner: set to Kris Zyp

I notice that dstore (theoretically the third generation of the Dojo store API) has https://github.com/SitePen/dstore/blob/master/LocalDB.js, which IIUC uses localStore if indexedDB isn't available. I don't know why dojox/store/LocalDB doesn't do that but I guess the feature could be backported from dstore to dojox.

I might be getting confused though; I haven't studied all these different forms of local storage.

comment:2 Changed 4 years ago by dylan

Owner: changed from Kris Zyp to Akira Sudoh
Status: newpending

IndexedDB and WebSQL are the interfaces provided via LocalDB in dojox/store, whereas dstore supported IndexedDB, WebSQL, and LocalStorage?.

Is there a reason to not just use dstore now, in place of dojo/store, when you want these capabilities?

comment:3 Changed 4 years ago by Akira Sudoh

Status: pendingnew

This is for Dojo/TodoMVC example (http://todomvc.com/examples/dojo/), and wasn’t sure if using dstore is applicable there. That said, if people think if dstore is the way to go there, I can update the Dojo/TodoMVC example to use dstore and we can close this ticket.

comment:4 Changed 4 years ago by dylan

Resolution: patchwelcome
Status: newclosed

asudoh and I discussed this. Decision is to switch to using dstore in the todomvc reference app, since it supports localStorage.

If someone wants to backport the enhancement, we'll review and accept the patch, otherwise we're not going to address this at this time.

Note: See TracTickets for help on using tickets.