Opened 4 years ago
Closed 4 years ago
#18438 closed defect (fixed)
Loader only strips strict-mode directive with double quotes
| Reported by: | Bryan Forbes | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8.11 |
| Component: | Loader | Version: | 1.10.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Currently, the loader, when configured with stripStrict: true only strips "use strict" and not 'use strict'. The regular expression should be updated to strip the single-quoted version as well. I will be submitting a pull request to address this issue.
I found this issue when writing intern tests. The code coverage instrumentation does not work in strict mode since it accesses global objects and escodegen rewrites "use strict" as 'use strict'.
Change History (3)
comment:1 Changed 4 years ago by
| Description: | modified (diff) |
|---|---|
| Priority: | undecided → high |
comment:2 Changed 4 years ago by
comment:3 Changed 4 years ago by
| Milestone: | tbd → 1.8.11 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in master ( https://github.com/dojo/dojo/commit/73086f08fb5728c01df710f824257a29a8e5a02c ), backported to 1.10 ( https://github.com/dojo/dojo/commit/26623de3903a994971026c6e2b3c0976742fb0ab ), 1.9 ( https://github.com/dojo/dojo/commit/fe5192eb18899d312d0013de90a7d102e9bfe9c9 ), and 1.8 ( https://github.com/dojo/dojo/commit/e04f560cc7a7198f09d7b368c3d25d9871937fa7 ).
PR: https://github.com/dojo/dojo/pull/129