Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18436 closed defect (fixed)

FindReplace Plugin not working in IE11

Reported by: eoinocon Owned by: Ed Chatelain <ed.chatelain@…>
Priority: undecided Milestone: 1.7.9
Component: Editor Version: 1.10.3
Keywords: Cc:
Blocked By: Blocking:

Description

Noticed a problem in IE11 with the FindReplace? plugin. Find does not find or highlight the searched for text within the editor.

Can be seen on the Basic Usage example in the Documentation: http://dojotoolkit.org/reference-guide/1.10/dojox/editor/plugins/FindReplace.html

Attachments (2)

FindReplace.js (26.9 KB) - added by Ed Chatelain 5 years ago.
Updated dojox/editor/plugins/FindReplace.js
FindReplace.2.js (26.7 KB) - added by eoinocon 5 years ago.
Updated FindReplace?.js

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by bill

Component: GeneralEditor

comment:2 Changed 5 years ago by Ed Chatelain

In IE11 document.selection is no longer available, but neither is window.find() which is used on the other browsers. For IE11 the doc says: "selection is no longer supported. Starting with Internet Explorer 11, use getSelection."

This works to get around much of this error, (I will attach an update which gets the first Find, Replace and Replace All working), but this fix does not work to find the next occurrence starting at the cursor position. I have not been able to get it to search from the current cursor position because the object returned by getSelection() does not work with createRange() like selection used to.

If anyone knows how to get a TextRange? for the current cursor position on IE11 to use with txtRg.setEndPoint() I would appreciate the input.

Changed 5 years ago by Ed Chatelain

Attachment: FindReplace.js added

Updated dojox/editor/plugins/FindReplace.js

comment:3 Changed 5 years ago by eoinocon

I've made some progress on the issue, but still having problems where there are multiple instances of the the text that is being searched for and the user clicks away from the selected text between Find button presses.

For example if there are multiple instances of the search text showing in the editor. Pressing Find will take you to the first, second, third etc. But if you click elsewhere on the editor between Find presses, the next Find continues on from the last position rather than the new cursor position.

Changed 5 years ago by eoinocon

Attachment: FindReplace.2.js added

Updated FindReplace?.js

comment:4 Changed 5 years ago by Ed Chatelain

Thanks eoinocon, are you covered by a CLA? If you work for IBM you are covered by the (IBM, CCLA), if not see http://dojofoundation.org/about/claForm Thanks, Ed

comment:5 Changed 5 years ago by eoinocon

Hi Ed, yes, I'm an employee

comment:6 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

Owner: set to Ed Chatelain <ed.chatelain@…>
Resolution: fixed
Status: newclosed

In 140032595d389af892901f5016ad6cef43c28c69/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 1ddeff7960956f8a33b71a7e34a9bf39c0bba364/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 9eae1051c04ac69aefc120ec545d25398a0f6f07/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In 768b5a5fd6e7c1f400cb023e4e594bbaf040d489/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by Ed Chatelain <ed.chatelain@…>

In e47af749a22c3a5edd06db5c9f7a2c1673cce125/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:11 Changed 5 years ago by Ed Chatelain

Milestone: tbd1.7.9
Note: See TracTickets for help on using tickets.