Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#18434 closed defect (fixed)

ComboBox does not honor 'type' property. (Hard-coded into template.)

Reported by: leftium Owned by: bill
Priority: undecided Milestone: 1.11
Component: Dijit - Form Version: 1.10.1
Keywords: Cc:
Blocked By: Blocking:

Description

Steps to reproduce:

  1. Open http://jsfiddle.net/Leftium/4vwL6pqq/
  2. Inspect the ComboBox? dijit

Expected results:

  • The input element of the dijit has type=url.
  • (iOS Safari) displays special keyboard for url entry.

Actual results:

  • The input element of the dijit has type=text.
  • (iOS Safari) displays normal keyboard.

Proposed fix:

Use variable substitution in the template like the other dijits (TextBox?, ValidationTextBox?) that work as expected. In file dijit/form/templates/DropDownBox.html: type="text" -> type='${type}'

Change History (4)

comment:1 Changed 5 years ago by bill

I see that the fiddle doesn't work correctly (thanks for the test case) but dijit/form/templates/DropDownBox.html already has a variable for type:

<input ${!nameAttrSetting} type="${type}" ...

Not sure why it isn't working.

comment:2 Changed 5 years ago by bill

Milestone: tbd1.11
Owner: set to bill
Status: newassigned

Woops, nevermind I was looking at the wrong file. :-) OK yes, it makes sense to update the template like you said.

comment:3 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 8753431807d55ac2a97a4d92504a4bc04c943241/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 4 years ago by Bill Keese <bill@…>

In 3a426c84a9a2220a9c4a810afff8a9683ece8c95/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.