Opened 6 years ago
Closed 6 years ago
#18430 closed defect (fixed)
[patch][cla] dojox/form/HorizontalRangeSlider - keep min/max consistent when in RTL mode
| Reported by: | Nick Nisi | Owned by: | bill |
|---|---|---|---|
| Priority: | low | Milestone: | 1.11 |
| Component: | DojoX Form | Version: | 1.10.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Getting the value of a dojox/form/HorizontalRangeSlider returns an array with the order [min, max].
Getting the value of a dojox/form/HorizontalRangeSlider in RTL mode returns an array with the order [max, min].
Getting the value of a dojox/form/VerticalRangeSlider returns an array with the order [max, min].
It would be nice to have consistency in the order of this array, regardless of the type (vertical or horizontal) or the dir setting. However, this would be a breaking change.
Change History (5)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
| Milestone: | tbd → 1.11 |
|---|---|
| Owner: | changed from dante to bill |
| Priority: | undecided → low |
| Status: | new → assigned |
| Summary: | dojox/form/HorizontalRangeSlider - keep min/max consistent when in RTL mode → [patch][cla] dojox/form/HorizontalRangeSlider - keep min/max consistent when in RTL mode |
Given that it's a dojox widget, I'm less concerned with the changing being breaking, since it fixes an inconsistency.
Bill, do you have an opinion on this?
comment:3 Changed 6 years ago by
Oh, I think we should definitely check it in. I was going to, but I just wanted to test it first.
comment:4 Changed 6 years ago by
OK, I confirmed with trunk/dojox/form/tests/test_RangeSlider.html?dir=rtl that it fixes the ordering problem. I'll push the change.
comment:5 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Submitted pull request https://github.com/dojo/dojox/pull/159