_WidgetBase: isLeftToRight() always returns false if dir prop is uppercase

[bill]

If dir property value is uppercase dijit/_WidgetBase.isLeftToRight will always return false as it's checking this.dir == "ltr" (but this.dir = "LTR")

isLeftToRight: function(){
           // summary:
           //        Return this widget's explicit or implicit orientation (true for LTR, false for RTL)
           // tags:
           //        protected
           return this.dir ? (this.dir == "ltr") : domGeometry.isBodyLtr(this.ownerDocument); //Boolean
},

People usually put dir in lowercase, but the HTML specs, except for XHTML, allows for uppercase. The HTML4.01 spec mandates that the dir attribute is case insensitive [1], while the XHTML1.1 spec refers to it as lowercase [2]. The HTML5 spec [3] does also allow for case insensitive attributes [4].

[1] ​http://www.w3.org/TR/html401/struct/dirlang.html#h-8.2 [2] ​http://www.w3.org/TR/xhtml-modularization/abstract_modules.html#s_bdomodule [3] ​http://www.w3.org/TR/html5/dom.html#the-dir-attribute [4] ​http://www.w3.org/TR/html5/infrastructure.html#enumerated-attribute

[Bill Keese <[email protected]…>]

In ed4fe7840eff7a266d635e03c887769909bf718d/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 4dce657af4e136ca6a9ccf4a372028522037e61b/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In c59dd75e098b7d85e122503b1f7c5490e7ab3742/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Bill Keese <[email protected]…>]

In 7bb41eeb0e1ed86d425c77a588ff3905a0241ec5/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?