Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18400 closed defect (fixed)

_WidgetBase: isLeftToRight() always returns false if dir prop is uppercase

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.10.3
Component: Dijit Version: 1.10.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

If dir property value is uppercase dijit/_WidgetBase.isLeftToRight will always return false as it's checking this.dir == "ltr" (but this.dir = "LTR")

isLeftToRight: function(){
           // summary:
           //        Return this widget's explicit or implicit orientation (true for LTR, false for RTL)
           // tags:
           //        protected
           return this.dir ? (this.dir == "ltr") : domGeometry.isBodyLtr(this.ownerDocument); //Boolean
},

People usually put dir in lowercase, but the HTML specs, except for XHTML, allows for uppercase. The HTML4.01 spec mandates that the dir attribute is case insensitive [1], while the XHTML1.1 spec refers to it as lowercase [2]. The HTML5 spec [3] does also allow for case insensitive attributes [4].

[1] http://www.w3.org/TR/html401/struct/dirlang.html#h-8.2 [2] http://www.w3.org/TR/xhtml-modularization/abstract_modules.html#s_bdomodule [3] http://www.w3.org/TR/html5/dom.html#the-dir-attribute [4] http://www.w3.org/TR/html5/infrastructure.html#enumerated-attribute

Change History (7)

comment:1 Changed 5 years ago by bill

Description: modified (diff)

comment:2 Changed 5 years ago by bill

Description: modified (diff)

comment:3 Changed 5 years ago by bill

Milestone: tbd1.10.3
Status: newassigned

comment:4 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In ed4fe7840eff7a266d635e03c887769909bf718d/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by Bill Keese <bill@…>

In 4dce657af4e136ca6a9ccf4a372028522037e61b/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Bill Keese <bill@…>

In c59dd75e098b7d85e122503b1f7c5490e7ab3742/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Bill Keese <bill@…>

In 7bb41eeb0e1ed86d425c77a588ff3905a0241ec5/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.