#18400 closed defect (fixed)
_WidgetBase: isLeftToRight() always returns false if dir prop is uppercase
Reported by: | bill | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.10.3 |
Component: | Dijit | Version: | 1.10.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
If dir property value is uppercase dijit/_WidgetBase.isLeftToRight will always return false as it's checking this.dir == "ltr" (but this.dir = "LTR")
isLeftToRight: function(){ // summary: // Return this widget's explicit or implicit orientation (true for LTR, false for RTL) // tags: // protected return this.dir ? (this.dir == "ltr") : domGeometry.isBodyLtr(this.ownerDocument); //Boolean },
People usually put dir in lowercase, but the HTML specs, except for XHTML, allows for uppercase. The HTML4.01 spec mandates that the dir attribute is case insensitive [1], while the XHTML1.1 spec refers to it as lowercase [2]. The HTML5 spec [3] does also allow for case insensitive attributes [4].
[1] http://www.w3.org/TR/html401/struct/dirlang.html#h-8.2 [2] http://www.w3.org/TR/xhtml-modularization/abstract_modules.html#s_bdomodule [3] http://www.w3.org/TR/html5/dom.html#the-dir-attribute [4] http://www.w3.org/TR/html5/infrastructure.html#enumerated-attribute
Change History (7)
comment:1 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 6 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 6 years ago by
Milestone: | tbd → 1.10.3 |
---|---|
Status: | new → assigned |
comment:4 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In ed4fe7840eff7a266d635e03c887769909bf718d/dijit: