Changes between Initial Version and Version 2 of Ticket #18388


Ignore:
Timestamp:
Nov 26, 2014, 10:34:38 PM (6 years ago)
Author:
bill
Comment:

As that check-in comment implies, the idea is to have form submission etc. work correctly, for a normal non-shift click of a button in a form.

If the user does a shift-click on a button, I'm not sure what's supposed to happen. Is that supposed to submit the form (if the button is type=submit and inside a form)? If not, we could just call _onClick(e) in that case.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18388 – Description

    initial v2  
    55User Rick Lacy on the community forum writes:
    66
    7 In _ButtonMixin.js there is an internal __onClick method.  When this gets a hold of the click event, it tries to call the click method on some hidden value dom node.  The trouble is, I don't think passing e to this click method does anything.  The real event is clobbered and by the time your code executes, it's this new event.   
     7In _ButtonMixin.js there is an internal  `__onClick` method.  When this gets a hold of the click event, it tries to call the click method on some hidden value dom node.  The trouble is, I don't think passing e to this click method does anything.  The real event is clobbered and by the time your code executes, it's this new event.   
    88
    99Workaround:
    1010
     11{{{
    1112 __onClick: function(/*Event*/ e){
    1213                        /* summary:
    … …  
    2526                        return false;
    2627                },
     28}}}