Changes between Initial Version and Version 1 of Ticket #18367, comment 1


Ignore:
Timestamp:
Nov 14, 2014, 10:09:12 PM (7 years ago)
Author:
Lukas Kubasek
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18367, comment 1

    initial v1  
    1 I have looked further into the source code and it looks like that changes in '''NumberTextBox''' introduced as part of 1.10 caused this issue.
     1I have looked further into the source code and it looks like that changes in '''NumberTextBox''' introduced as part of 1.10.0 caused this issue.
    22
    3 The new function getDecimalInfo() loads a default pattern for the current locale (which is {{{#,##0.###}}} in my en_GB case). The precision (3 decimal places) given by this default pattern should never be used later since the 'places' constraint definition overrides the decimal precision given by the pattern.
     3The new function getDecimalInfo() loads the default pattern for current locale (which is {{{#,##0.###}}} in my en_GB case). The precision (3 decimal places) given by this default pattern should never be used later since the 'places' constraint definition overrides the decimal precision given by the pattern.
    44
    5 The main issue is then in the '''filter()''' function that was changed for 1.10.0 (commit https://github.com/dojo/dijit/commit/f018c601b407592956dd56cd41a5edfe332d55d2 fixing https://bugs.dojotoolkit.org/ticket/17955). This function executes an implicit rounding for some reason. This rounding uses the decimal precision given by the default pattern (3 decimal places) which does not correspond to the places constraint definition set to {0,4}. This change therefore breaks the 'places' constraint given by range.
     5The main issue is then in the '''filter()''' function that was changed for 1.10.0 (commit https://github.com/dojo/dijit/commit/f018c601b407592956dd56cd41a5edfe332d55d2 fixing https://bugs.dojotoolkit.org/ticket/17955). This function executes an implicit rounding for some reason. This rounding uses the decimal precision given by the default pattern (3 decimal places) which does not correspond to the places constraint definition set to {0,4}. This change therefore breaks the range based 'places' constraint feature.