Opened 5 years ago

Closed 4 years ago

#18366 closed defect (fixed)

Incorrect handling of "${scope}type" attribute in parser

Reported by: Jason Cheatham Owned by: bill
Priority: undecided Milestone: 1.11
Component: Parser Version: 1.10.2
Keywords: Cc:
Blocked By: Blocking:

Description

In parser.js line 282 (as of commit fb7a76cb), the parser aliases an element's "${scope}type" attribute (e.g., "dojotype", "myScopetype", etc.) to "dojoType". This alias is ignored by the attribute processing that starts at line 288, which assumes all the attribute aliases will be lowercase. The ${scope}type attribute should instead be aliased to "dojotype" (all lowercase).

Change History (3)

comment:1 Changed 5 years ago by bill

Thanks for the report.

dojo/tests/parser-args.html test checks for data-myscope-type rather than data-dojo-type but I guess we don't have tests for the old myscopeType=... instead of dojoType=... syntax.

So, you (if you've filed a CLA) or I need to add a test case before changing the code you mentioned.

comment:2 Changed 4 years ago by bill

Milestone: tbd1.11
Status: newassigned

OK, I will add the test and check in a fix.

comment:3 Changed 4 years ago by bill

Resolution: fixed
Status: assignedclosed

Fixed in 8107d124ab2f11b020a5bb87b9dc167c293c1aff.

Note: See TracTickets for help on using tickets.