Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18363 closed defect (fixed)

ConfirmDialog: wrong relative use of "../dojo/_base/declare" in dijit/ConfirmDialog

Reported by: Marko Reiprecht Owned by: bill
Priority: undecided Milestone: 1.10.3
Component: Dijit Version: 1.10.2
Keywords: Cc:
Blocked By: Blocking:

Description

The files

dijit/_ConfirmDialogMixin.js dijit/ConfirmDialog.js dijit/ConfirmTooltipDialog.js

use a relative AMD import "../dojo/_base/declare" instead of the normal "dojo/_base/declare" like in any other dijit file.

I think this breaks the package location independence, because it enforces that the dijit package has to be deployed on the same level as the dojo package, which is not always the case.

Change History (4)

comment:1 Changed 6 years ago by ben hockey

nice catch - you're right that those shouldn't be relative.

comment:2 Changed 6 years ago by bill

Component: GeneralDijit
Milestone: tbd1.10.3
Owner: set to bill
Status: newassigned
Summary: Wrong relative use of "../dojo/_base/declare" in dijit/ConfirmDialogConfirmDialog: wrong relative use of "../dojo/_base/declare" in dijit/ConfirmDialog

Thanks for the catch, I'll fix and backport to 1.10.

comment:3 Changed 6 years ago by Bill Keese <[email protected]…>

Resolution: fixed
Status: assignedclosed

In 91712d82752a6744f3fc2619a787cea3e61494b1/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by Bill Keese <[email protected]…>

In 9c782017274f7c650d78fdda74e5000fbe0033e1/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.